On Wed, May 28, 2008 at 2:41 PM, James Turnbull <[EMAIL PROTECTED]> wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Russ Allbery wrote: >> "Paul Lathrop" <[EMAIL PROTECTED]> writes: >> >>> That was my understanding as well. Hence "in the course of normal >>> development" i.e. I'm making a fix and while I make that fix I do a M-x >>> indent-region so the code is readable, which fixes a whitespace >>> problem... Or I fix a typo in a comment I notice while I'm working... >>> >>> If I have to isolate those changes from my patches I'm gonna stop trying >>> to contribute patches, because it seems a nightmare to me to try to >>> isolate general development from fixing things you notice during that >>> development. >> >> Certainly you're allowed to change whitespace and reindent regions of code >> that you're editing anyway. The point of this sort of rule is to not add >> unrelated whitespace changes to the same patch. In other words, not >> reformatting the rest of the file in the same commit as your code edit. >> You can of course do it as an immediately following separate commit. >> >> The reason for this rule is mostly so that you can get a meaningful >> history and see when a particular change was introduced. Formatting >> changes always cause problems for that, but at least if any formatting >> changes are their own change, you can skip over them and know you can keep >> searching backwards when using something like git blame. Otherwise, you >> have to carefully compare the code to see if there are semantic changes >> hidden in the whitespace changes. >> > > What Russ said. The point of this rule is not to make unrelated > whitespace/spelling fixes/doco updates in a commit. If it's related to > the actual purpose of the commit then there is no issue. > > Thanks > > James > > - -- > James Turnbull ([EMAIL PROTECTED]) > Author of: > * Pulling Strings with Puppet > (http://www.amazon.com/gp/product/1590599780/) > * Pro Nagios 2.0 > (http://www.amazon.com/gp/product/1590596099/) > * Hardening Linux > (http://www.amazon.com/gp/product/1590594444/) > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.7 (Darwin) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iD8DBQFIPdGD9hTGvAxC30ARAmL5AKCTV9yPnOTjs9dYuKO3w7AA4WntgACfUQy+ > LbbUJA8fXZhhmIw4srJPtcA= > =gAPY > -----END PGP SIGNATURE-----
Cool. Sorry I'm a bit slow --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
