On 14/10/08 21:49, Luke Kanies wrote:
> On Oct 11, 2008, at 10:33 AM, Brice Figureau wrote:
>
>> Hi,
>>
>> I'm still progressing through the language tickets, fixing and adding
>> interesting features. This time, this is resource collect overriding.
>>
>> Here is an example usage:
>>
>> @user {
>> "brice":
>> uid => 1000,...
>> }
>>
>> and later
>> User <| name == brice |> {
>> uid => 2000
>> }
>>
>> I tried to have the minimal impact on the existing collector code so
>> to not introduce new bugs. Unfortunately I couldn't find a way to
>> write
>> the grammar without duplicating the AST::Collection setup code.
>>
>> Please review and comment as usual :-)
>
> Sorry I'm taking longer than normal on this code review.
>
> I'm not quite comfortable pushing this into 0.24.6, since I think it
> needs a bit more thought to see how it fits into the language, so I
> don't want to rush it.
If you want my opinion, I don't think this should not be merged in a
subrelease, this looks like stuff for 0.25. I don't mind if that's not
even merged if you don't want this feature (I wasn't the one who
requested this feature, I'm not even sure I'd use it in production).
That was fun and easy to add thanks to puppet modularity, though :-)
> I'll assess the code this week, hopefully.
OK. There is no hurry on my side, the job is done.
> I assume these overrides follow the same rules as current overrides --
> only possible within a subclass?
Maybe I'm plain wrong, but I don't think this restriction is necessary,
since after all if the original resource is not collected/realized it
doesn't even exist. So the override is just that we are "instantiating"
a different resource than what was exported/virtualized.
Thanks,
--
Brice Figureau
Days of Wonder
http://www.daysofwonder.com
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
