Hi Peter,

On 23/02/09 14:50, Peter Meier wrote:
> Hi
> 
>> So, if you want to have both the performance increase _and_ the bug fix
>> for #1824, you can:
>>  * run lastest 0.24.x git HEAD, which is pretty stable
> 
> this is what I'm doing, due to the same reasons.
> Besides that I'm now hit by:
> http://projects.reductivelabs.com/issues/2010 and I'm not yet sure how
> severe this problem is.

Please try the following patch (which is on top of 0.24.x):
http://github.com/masterzen/puppet/tree/tickets/0.24.x/2010

It contains code to "fix" your database (ie removing all those extra old 
resources of same reference), and more protective code (so it should 
resist to your current db).

Do you run your mysql storedconfig database on innodb?
Because the only way of producing the kind of multiple resource of same 
reference behaviour you got would have been a crash in the storeconfig 
process, with the transaction not rolled back, which would leave some 
old resources.

The code before my optimization patch was immune to this behaviour, but 
there was nothing to prevent it, so the problem would still have been there.

What I'd think would be interesting is to see if your puppetmaster still 
produces those "duplicated" resources (the one I had a look to where 
from last September or August). I suggest you add an unique index on 
(title,restype), and wait for it to fail.

I inspected my own storedconfig db and I do not have multiple resources 
of the same reference, that's why I didn't see the issue.

Thanks,
-- 
Brice Figureau
Days of Wonder
http://www.daysofwonder.com

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com
To unsubscribe from this group, send email to 
puppet-dev+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to