Luke Kanies wrote: >>> It's apparently already been merged, so now it's too late to fix. >>> >> Did you not want it merged? One shouldn't mark it "Ready for Checkin" >> then. :) > > > We almost need a 'ready for review' phase - everyone's patches have to > go through my review before merging, but there's no such clear line > for my own code (one assumes I've reviewed it, right?). > > I guess I'd just say it's safe to give people a day or two to review > my code before merging, in most cases, but it's often safe to just > merge, too. >
Just mark it "Ready for Testing" then and then "Ready for Checkin" when it's reviewed. Regards James -- Author of: * Pulling Strings with Puppet (http://www.amazon.com/gp/product/1590599780/) * Pro Nagios 2.0 (http://www.amazon.com/gp/product/1590596099/) * Hardening Linux (http://www.amazon.com/gp/product/1590594444/)
signature.asc
Description: OpenPGP digital signature
