On Jul 23, 2009, at 10:55 PM, David Schmitt wrote:

>
> Luke Kanies wrote:
>> Hi all,
>>
>> I'm trying to figure out which signal should do what with ticket
>> #2239, or if we should even keep the existing behaviour.
>>
>> If you send a signal to puppetd when it's in the middle of a
>> transaction, what behaviour do you expect?
>>
>> Do you expect it to exit as soon as it is safe? (I.e., after it syncs
>> the current resource.)  Or after it finishes the transaction?
>>
>> Currently it exits after it finishes the transaction, but I'm  
>> thinking
>> this is just the wrong behaviour -- it should exit as quickly as
>> possible.
>>
>> What do you think?
>
> The standard-case is probably TERM on shutdown. puppet should react  
> fast
> to avoid stalling the shutdown and being KILLed in mid-work.

Yep, this problem is what prompted the ticket.

>
> The other cases that come to my mind are restarting puppetd from  
> within
> a transaction and aborting a --test run from the commandline with ^C.
> The former probably should wait until the end of the (presumably
> bootstrap) transaction, while the latter should abort immediately  
> after
> the current resource (and say so, the current message on ^C is not  
> very
> descriptive).


Should we just delay restarts on HUPs but not on INT or KILL?

Because I am reminded now that this 'don't restart mid transaction' is  
exactly why we have the current behaviour.

-- 
A Chemical Limerick:
     A mosquito cried out in pain:
     "A chemist has poisoned my brain!"
     The cause of his sorrow
     was para-dichloro
     diphenyltrichloroethane
     -- Dr. D. D. Perrin
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to