Isn't the 'when' here redundant, since there's no else? On Dec 10, 2009, at 2:05 PM, Markus Roberts wrote:
> The refactoring in 8f60f0c50ee3dfb6453644f5dcded58e6e80e8bb lost the > return code--should be true in all non-exception cases--and this was > causing a false failure when the result was checked higher up. > > Signed-off-by: Markus Roberts <[email protected]> > --- > lib/puppet/util/backups.rb | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/lib/puppet/util/backups.rb b/lib/puppet/util/backups.rb > index 4ab6777..470d6d1 100644 > --- a/lib/puppet/util/backups.rb > +++ b/lib/puppet/util/backups.rb > @@ -26,8 +26,9 @@ module Puppet::Util::Backups > info "Recursively backing up to filebucket" > Find.find(self[:path]) { |f| > backup_file_with_filebucket(f) if File.file?(f) } > when "file"; backup_file_with_filebucket(file) > - when "link"; return true > + when "link"; > end > + true > end > > def perform_backup_with_backuplocal(fileobj, backup) > -- > 1.6.4 > > -- > > You received this message because you are subscribed to the Google > Groups "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected] > . > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en > . > > -- Getting caught is the mother of invention. --Robert Byrne --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
