>> when "file"; backup_file_with_filebucket(file) >> - when "link"; return true >> + when "link"; >> end >> + true >> end >>
> Isn't the 'when' here redundant, since there's no else? Yes. I left it in because I felt it made the intent slightly clearer (we aren't neglecting the possibility of links, we're explicitly saying that we skip them) and because I started down the road of refactoring/cleanup, woke up twenty minutes later several miles from base camp wearing a pith helmet and holding a sap stained machete, stashed my changes and went back to the minimal change that actually fixed the problem. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
