I am fine with this patch, but only because most other ruby projects
do the same, and it can sometimes be confusing to differentiate
between the tabs for the code and the tests for a given class.
Given that it's obviously easy to change your macro to run the test
from root of the git repo, this is a lot more work than just fixing
your macro to work correctly.
That being said, your at least the third person to recommend this, and
if others agree I won't stand in the way.
On Jun 12, 2010, at 11:06 AM, Matt Robinson wrote:
I often run individual specs from within my editor which has the
effect of running the spec from the same directory. I know most
people don't have that particular problem, but in general I think
things should be named in a way that doesn't cause these sorts of
problems. So yes, new spec files should end in _spec.
Matt
On Sat, Jun 12, 2010 at 1:50 AM, Brice Figureau <[email protected]
> wrote:
On 12/06/10 00:41, Matt Robinson wrote:
> Some spec files like active_record.rb had names that would confuse
the
> load path and get loaded instead of the intended implentation when
the
> spec was run from the same directory as the file.
I'm not sure I get the reasoning behind this patch: when does it
happen
that you run the spec from the directory of the "speced" file?
And, does that mean from now on every new spec file should end with
_spec?
--
Brice Figureau
My Blog: http://www.masterzen.fr/
--
You received this message because you are subscribed to the Google
Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected]
.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en
.
--
You received this message because you are subscribed to the Google
Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected]
.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en
.
--
An expert is a person who has made all the mistakes that can be made
in a very narrow field. - Niels Bohr
---------------------------------------------------------------------
Luke Kanies -|- http://puppetlabs.com -|- +1(615)594-8199
--
You received this message because you are subscribed to the Google Groups "Puppet
Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
