On Sat, Sep 18, 2010 at 3:02 AM, Brice Figureau < [email protected]> wrote:
> > Are we sure that safeevaluate always returns an array? I think I > remember you sent a patch earlier about this, but I don't exactly > remeber the details. > Glad you asked, Brice, because I didn't verify that as carefully as I should have when I made the patch. I just checked, and fortunately, yes. @arguments is always an ASTArray, and ASTArray.safeevaluate always returns an Array. So we are ok. The patch you are remembering ( http://groups.google.com/group/puppet-dev/browse_thread/thread/c3cabc3ca5349d48?pli=1) tightened up a lot of these kinds of guarantees, but sadly we can't count on the tighter guarantees, because that patch is slated for 2.7, and this patch is a hotfix for 2.6. (Hmm, this is probably a flaw in our process. I use "rake mail_patches" to send my patches to the list, and it doesn't include any information in the e-mail to indicate which branch a patch is intended for.) Paul -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
