James Turnbull <[email protected]> writes:
> Luke Kanies wrote:
>> On Oct 27, 2010, at 1:54 PM, Jeff McCune wrote:
>>
>>> On Wed, Oct 27, 2010 at 4:49 PM, Thomas S Hatch <[email protected]> wrote:
>>>> If it is moved off list, please maintain a public list where we can 
>>>> continue
>>>> to receive these posts.
>>> +1 for maintaining a public list.  I personally find it very useful.
>>>
>>> I also think there should just be one list for code review and
>>> patches.  It's going to be confusing and possibly create information
>>> sinkholes if community patches go to puppet-dev but puppet-labs
>>> developer patches go somewhere else.
>>
>> This seems like a good middle-ground.  We could repurpose the existing
>> puppet-commits list, or (of course) make a new one.

Personally, I don't mind the review of patches on the list - though it can be
challenging when they sometimes get whitespace-mangled during the reply.
However, I can see this and think the middle ground is a good deal...

> So my concern here is the potential for confusion between what's
> reviewed/is/isn't/etc.  Already we have issues where patches slip through
> the cracks - both internal and community patches.  If we set-up up a
> different list it should ONLY be if we've built a more robust review
> process.

I absolutely agree with this.

I am going to mention patchwork again - a bunch of Linux kernel projects use
it to monitor patches that go past on their lists; it could easily capture, in
fact, not just the deliberate dev list things, but also the user list set of
patches.

    http://ozlabs.org/~jk/projects/patchwork/

You can see it in anger here: https://patchwork.kernel.org/


It deliberately acts as a mechanism to capture patches, and review, in a form
designed for long term archival and access - without replacing the mailing
list as the primary mechanism for communication.


Otherwise I am gonna advocate Gerit, which every single project I know that
has adopted has within a month had a rash of "wow, this is like the SVN to GIT
change for us!" comments.

Gerit is a much bigger change of process, though, than patchwork.

        Daniel
-- 
✣ Daniel Pittman            ✉ [email protected]            ☎ +61 401 155 707
               ♽ made with 100 percent post-consumer electrons

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to