Brice, I see you haven't had time to write tests for this patch, and I understand it's not very high priority. I'd hate to see this patch languish on the list since it's fairly simple, fixes an issue, and is hard to test because of it's relationship with RDoc. I'd be okay with merging this in and opening a separate ticket as a reminder to write some tests for this file. Would anyone object to that?
On Fri, Oct 29, 2010 at 12:18 AM, Brice Figureau <[email protected]> wrote: > On Thu, 2010-10-28 at 21:14 -0700, Matt Robinson wrote: >> I've verified this works and fixes the error you get if there's non >> puppet files. Brice, any chance you could write a test to motivate >> this change? I know the puppet_generator.rb doesn't have any tests, >> but I see you wrote the original code too, so hopefully it won't be >> that difficult for you. > > Unfortunately it is really a difficult task if we want it to be done > correctly (or if not difficult, a long and tedious). > Why? Because this whole code is really intimate with the infamous RDoc. > Of course I could stub everything and test only the added change, but in > the end I'm not even sure it'll bring anything. > > I'll see what I can do. > -- > Brice Figureau > Follow the latest Puppet Community evolutions on www.planetpuppet.org! > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
