On 1 February 2011 01:57, Daniel Pittman <[email protected]> wrote: > On Sun, Jan 30, 2011 at 09:28, Paul Nasrat <[email protected]> wrote: >> On 28 January 2011 18:44, Daniel Pittman <[email protected]> wrote: >>> From: Daniel Pittman <[email protected]> >>> >>> We have moved to rspec2 for puppet, and facter should follow suit. >> >> +1 with minor query > > [...] > >>> index b7e3089..c104856 >>> --- a/spec/unit/util/uptime.rb >>> +++ b/spec/unit/util/uptime.rb >>> @@ -7,7 +7,7 @@ require 'facter/util/uptime' >>> describe Facter::Util::Uptime do >>> >>> describe ".get_uptime_seconds_unix" do >>> - context "when /proc/uptime is available" do >>> + describe "when /proc/uptime is available" do >> >> I thought context within describe is still supported >> >> http://relishapp.com/rspec/rspec-core/v/2-4/file/upgrade > > It is: when we went looking during the review and testing we didn't > actually find the right bit of documentation, so thought it was > uniformly disabled, not just at the top level. This hunk could have > been dropped, although I don't think that is strictly required.
Fine as I said it's fine to be describe everywhere for the moment +1 Paul -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
