On Feb 8, 2011, at 9:13 PM, Daniel Pittman wrote:

> On Tue, Feb 8, 2011 at 17:29, Garrett Honeycutt
> <[email protected]> wrote:
> 
> Looks reasonable, but:
> 
>> +    newproperty(:devices) do
>> +      desc "The devices property. Values: on | off"
>> +    end
> 
> ...these are going to get a bunch of people giving 'true' or 'false'
> as the value, so it would be good to accept that, and document it,
> here.
> 
> Otherwise, I don't see *any* validation of the documented values; they
> should certainly be added before this goes in (or my misconception
> about where they are hidden resolved).

You can just use:

newvalues :on, :off
aliasvalue :on, :true
aliasvalue :off, :false

Or something similar.

-- 
Between two evils, I always pick the one I never tried before.
    -- Mae West
---------------------------------------------------------------------
Luke Kanies  -|-   http://puppetlabs.com   -|-   +1(615)594-8199




-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to