On Feb 9, 10:21 am, James Turnbull <[email protected]> wrote:
> Garrett Honeycutt wrote:
> > * Alphabetized properties
>
> > * Added documentation for acceptable values
>
> > * Added the following properties:
> >     atime
> >     canmount
> >     checksum
> >     devices
> >     exec
> >     logbias
> >     nbmand
> >     readonly
> >     refquota
> >     refreservation
> >     setuid
> >     shareiscsi
> >     sharesmb
> >     version
> >     volsize
> >     vscan
> >     xattr
> >     zoned
> >     vscan
>
> We should use the value validation for each.  It is:
>
> newvalues :foo, :bar
>
> >From memory.
>
> James
>
> --
> James Turnbull
> Puppet Labs
> 1-503-734-8571

Agreed that all the values should be validated.

We currently are not doing validation and do not have all the
properties listed. I propose that we accept this patch, since it adds
the rest of the missing properties and create a new ticket to add
validation to the entirety of the properties. This gives will ensure
that we add functionality with this commit and have another ticket
solely for validation of all properties.

-g

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to