On Tue, 22 Mar 2011 23:35:09 +0100, Stefan Schulte wrote: > > The tests now work > - The provider-spec for the port type now uses the > »all_parsedfile_providers« helper to test correct file parsing. > - add a validate function to satisfy a failing test > - improve documentation of the type (including your corrections) > - changed separator in the title_pattern from : to /. This is the same > separator you can use when running getent (e.g. you can run »getent > services telnet/tcp« and get the correct line) > > I rebased on current next and squashed a few commits into a single one > because I think > it is easier for you to review them this way. If you disagree please let me > know and > I can send diffs based on the last patch series. > > There is currently one problem I'm trying to address tomorrow: All tests pass > (at least > on my system) while prefetch is still broken (#5605) so I want to at least > add a test > that will show this misbehaviour. > > -Stefan >
After looking through the patch series, it seems like it all should be squashed down into one commit. Normally, I'd agree about splitting a patch series apart as much as possible to get down to "logically consistent units". Given that you're essentially rewriting port from the ground up, it seems like the entire rewrite is the "logically consistent unit" for this series. Another reason to squash the entire series is that the tests don't pass in every commit in the patch series. Also, it looks like your GitHub branch isn't up to date? Again, thanks for putting in the work on this. I'm looking forward to seeing the next iteration of the patch series. -- Jacob Helwig
signature.asc
Description: Digital signature
