On 17/05/11 08:14, Michael Knox wrote: > Thanks, > I've updated my branch based on comments, and it works fine with a dummy > manifest that includes a single file change, changes to multiple files > and changes to a file with an alternative root. Also cherry-picked > Dominic's initial test cases. > > https://github.com/mikeknox/puppet/tree/feature/master/2728
Good work. Did you get a chance to look at my comments from the 28th? Just a couple of small things to keep it inline with the file provider. > But now I'm having a crash course in mocha/rspec test cases... > Most of the existing tests still pass except for the "augeas execution > integration" tests which now fail. > > I've made some updates, but it feels like the tests are too perscriptive > about how the provider is working internally rather than what it's > results should be. Yeah, they're very prescriptive because the entire Augeas type is stubbed, rather than being a "real" resource object. The pattern for specs has changed and it'd be good to get the test harness rewritten to follow the new style... probably best to file a new bug and perhaps somebody will pick it up. > I'm quite concerned that I need to be digging in the "augeas execution > integration" tests, but they seem to be quite sensitive to the changes > I've made in the provider. > > Does anybody have some suggestions on this? Try this patch instead: https://gist.github.com/979650 The /augeas/events/saved match is stubbed at the whole group of tests level so you don't need to mess with all of those tests. It's still a bit invasive, but the best you can really do with the file like it is I think. Cheers, -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
