ok, hopefully this is done ... the tests now run succesfully on my branch, and with Dominic's help there's some tests for this change.
On 19 May 2011 07:51, Dominic Cleal <[email protected]> wrote: > On 17/05/11 08:14, Michael Knox wrote: > > Thanks, > > I've updated my branch based on comments, and it works fine with a dummy > > manifest that includes a single file change, changes to multiple files > > and changes to a file with an alternative root. Also cherry-picked > > Dominic's initial test cases. > > > > https://github.com/mikeknox/puppet/tree/feature/master/2728 > > Good work. Did you get a chance to look at my comments from the 28th? > Just a couple of small things to keep it inline with the file provider. > > Yes, but I missed :show_diff, which I've now added in. > Yeah, they're very prescriptive because the entire Augeas type is > stubbed, rather than being a "real" resource object. The pattern for > specs has changed and it'd be good to get the test harness rewritten to > follow the new style... probably best to file a new bug and perhaps > somebody will pick it up. > New ticket ... https://projects.puppetlabs.com/issues/7592 Try this patch instead: https://gist.github.com/979650 > > Thanks. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
