On Mon, May 14, 2012 at 6:19 AM, Ken Barber <[email protected]> wrote:
> So I took on this bug this morning, which I'd been meaning to work on > for quite some time: > > http://projects.puppetlabs.com/issues/11156 > > But hit some snags when it came to testing on master. Here is my patch: > > https://github.com/kbarber/puppetlabs-ntp/commit/e96894fd8c3a308f1a68d4a5466a2795c0eba6ad > > (Now I presume I'm using puppetlabs_spec_helper in the correct way > here ... but I could be totally wrong. They way I followed the code, > the helper should have called Puppet's 'initialize_*' and 'clear_*' > capabilities geared towards tests. I think this is working - so kudos > to those who have worked on this.) > > However, I did hit a problem when I downloaded this commit into my > puppet master branch: > > 07a3c7fbdec0357e63f9bb7432fea8e773f6873c > > (enable Hiera to be the default terminus) > > So when I roll back to c9386b541e9ecf6c0daffde2825bad385ea4da2b I'm > all good again. I've put in a work-around: > > c.before :each do > Puppet[:data_binding_terminus] = 'none' > end > > Which works smashingly ... but its a workaround, and should belong elsewhere. > > My question here is - where should this be fixed now? This should be fixed in your code: Hiera is a mandatory component with the release of Telly, and disabling it for your tests is absolutely wrong. This is required to deliver the data/model separation, and will need to be installed everywhere that Telly is - for the master, and for apply. -- Daniel Pittman ⎋ Puppet Labs Developer – http://puppetlabs.com ♲ Made with 100 percent post-consumer electrons -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
