On Wednesday, October 24, 2012 2:57:08 AM UTC+11, Erik Dalén wrote: > > > I think trying to be extra speedy with reviewing and giving feedback on > external pull requests would be a great start for this. It might be more > time consuming and slow down development in the short run, but I think it > would give more external contributions and speed up development in the long > run. Basically regarding them as a VIP lane compared to internal ones or > something. >
I'm only new here but I agree with this. I recently signed the CLA in my personal capacity without any discussion with company lawyers (I don't think I need their permission to sign as myself do I?) and I got myself across the Puppet Labs development processes. I can understand why some people would find this a lot to learn just to submit a patch but I can also see why Puppet Labs would expect people who plan to make regular code submissions to follow the same processes as everyone else. I would imagine that it would be even more work for the Puppet Labs developers if everyone isn't following the same process and thus the real problem - which I think is allowing there to be a backlog of pull requests - would probably be exacerbated. I think it's fairly obvious though that if pull requests don't get looked at in a reasonable time frame then people just won't bother making them in the future. And some will get sufficiently annoyed that they'll use Chef or something other than Puppet, if they've got bugs that they've had to fix, and they feel no one can even be bothered reviewing them. I think Andy's idea of making public the team's priorities is also a great idea - although external contributors may find that, almost by definition, their personal interests may not align with Puppet Labs. External contributors are likely to be contributing in the first place because they have a very specific need that isn't otherwise likely to be looked at by Puppet Labs. And that's my case of course - fixing puppet & facter for versions of commercial Unix that you guys don't have access to that I need to make it work on. So I vote strongly for insisting that no internal Puppet Labs priorities can be allowed to divert the person assigned to looking at pull requests away from this greater priority. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To view this discussion on the web visit https://groups.google.com/d/msg/puppet-dev/-/quhkDbVAk0sJ. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
