Hi Jeff, Thanks for all your hard work and also for patiently explaining so much of the development process to me. All of the issues I raised are resolved.
Keep in mind however that #11612 is really a ticket about multiple issues and adding processorX facts was only one part. Maybe it should be closed and raised as separate tickets? Still to do, add physicalprocessorcount (this is also a headache on HP-UX) and add Hongbo Hu's bugfix for dealing with HP-UX NICs that have an asterisk after them. This could probably be put in straight away - but the question is are we going to use this opportunity to write proper unit tests for ip.rb? That might take me, personally, too far afield. See my comment at https://projects.puppetlabs.com/issues/11612#note-31 Best regards, Alex On Tuesday, November 6, 2012 2:32:46 PM UTC+11, Jeff McCune wrote: > > Alex, > > Thanks again for pinging us about these issues. Doing so really helps me > make sure I'm not letting valuable contributions slip through the cracks. > > At this point, I think all of these issues are resolved and are going to > be released in the next versions of Puppet and Facter. Is this the case, > or is there something I've overlooked and need to address at this time? > > Thanks again, > -Jeff > > > On Mon, Oct 15, 2012 at 5:30 PM, Alex Harvey <[email protected]<javascript:> > > wrote: > >> Hi Jeff, >> >> I've seen all your updates - thanks! In general I already have fixes >> ready for quite a few of them - I just needed them accepted/reviewed before >> I could proceed to submit. In a few other cases I'll update the tickets >> with more specific comments. >> >> Best regards, >> Alex >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> To view this discussion on the web visit >> https://groups.google.com/d/msg/puppet-dev/-/a9VFiluyRkIJ. >> >> To post to this group, send email to [email protected]<javascript:> >> . >> To unsubscribe from this group, send email to >> [email protected] <javascript:>. >> For more options, visit this group at >> http://groups.google.com/group/puppet-dev?hl=en. >> > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To view this discussion on the web visit https://groups.google.com/d/msg/puppet-dev/-/hPNgf3BOG5QJ. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
