On Tue, Nov 6, 2012 at 5:29 PM, Alex Harvey <[email protected]> wrote:
> Hi Jeff, > > Thanks for all your hard work and also for patiently explaining so much of > the development process to me. All of the issues I raised are resolved. > > Keep in mind however that #11612 is really a ticket about multiple issues > and adding processorX facts was only one part. Maybe it should be closed > and raised as separate tickets? Yes, I think we should leave 11612 as it is. Merged pending release is a state that is considered "closed," but it's a soft form of being closed. The ticket changes to the closed state when the change is actually released. Would you mind creating additional tickets for the following "still to do" items? One ticket for each actionable issue will help me streamline the changes through our system. > Still to do, add physicalprocessorcount (this is also a headache on HP-UX) > and add Hongbo Hu's bugfix for dealing with HP-UX NICs that have an > asterisk after them. This could probably be put in straight away - but the > question is are we going to use this opportunity to write proper unit tests > for ip.rb? That might take me, personally, too far afield. > I'd be happy to write the unit tests for ip.rb, but I do this sort of work when I have the opportunity, which is not all that frequently. If you could isolate the potential blocker of unit tests in it's own issue, it'll help keep the other issues streamlined. I'm also happy to file these tickets, but I think it will be faster and more clear if they come from you since I'm doing quite a bit of context switching across facter, puppet and stdlib at the moment. -Jeff -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
