This functionality is a fantastic improvement over the, already useful, data.pp functionality of the hiera_puppet backend. For me this means i can create modules with defaults without limiting the module to the specific defaults i can think of and have them easily over-ridable without modifying the module itself.
Great work! Thanks, Stefan Goethals. ps. Just let me know if you need more testing to be done. On Tue, Dec 4, 2012 at 11:34 PM, Garrett Honeycutt <garr...@puppetlabs.com>wrote: > On 12/4/12 2:38 PM, R.I.Pienaar wrote: > > > > > > ----- Original Message ----- > >> From: "ZipKid" <zipkid....@gmail.com> > >> To: puppet-users@googlegroups.com > >> Sent: Tuesday, December 4, 2012 11:10:13 PM > >> Subject: Re: [Puppet Users] in-module data with hiera > >> > >> Hello, > >> > >> I have tested the branch > >> https://github.com/ripienaar/puppet/tree/feature/master/16856. > >> The basic functionality of the data in the module seems to work as > >> desired. > >> Just a few things > >> - If only using the param auto-lookup not having a hiera.yaml file is > >> ok > >> - if there is NO hiera.yaml config file, calling hiera() causes an > >> error "Error 400 on SERVER: undefined method `include?' for > >> nil:NilClass" > >> - Having an empty hiera.yaml is ok when using a hiera(call) > >> - The lookup in the moduledata does not happen if only using the > >> auto-lookup of the class params, unless you manually specify > >> "module_data" as hiera backend. > >> - When using the hiera() call, specifying "module_data" as hiera > >> backend is not needed. > >> > >> I hope this helps. > > > > awesome, thanks a lot for taking the time to test it, I'll incorporate > > this feedback in a few weeks. > > > > do you think the basic approach will improve your workflow and lead > > to easier to share modules? > > > > Absolutely leads to modules that are easier to share. This functionality > is critical for releasing modules that work on different system types > without writing a bunch of conditional logic that replicates hiera. > Outstanding work. > > -g > > -- > Garrett Honeycutt > > 206.414.8658 > http://puppetlabs.com > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To post to this group, send email to puppet-users@googlegroups.com. > To unsubscribe from this group, send email to > puppet-users+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/puppet-users?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
