+2 here. I support the fix -- but not in a minor-revision of the tool. In our case, it was indeed a reasonably simple regex change everywhere, but the potential for failure around puppet-forge modules is massive here. I strongly recommend reverting this change and releasing it in a 3.xx version of Facter.
Matt Wise Sr. Systems Architect Nextdoor.com On Wed, Aug 27, 2014 at 5:49 AM, Konrad Scherer < [email protected]> wrote: > On 08/26/2014 04:42 PM, Will Hopper wrote: > >> Hi, Mark! >> >> >> Thanks for raising your concerns on this. This change was actually >> intentional, >> as we have been reporting the Ubuntu major release incorrectly for some >> time in >> Facter. >> >> >> In most platforms, splitting on the first ‘.’ of an X.Y.Z release would >> be a >> sane way of determining the major release, but Ubuntu does its versioning >> a bit >> differently. >> >> >> Given the Ubuntu release 10.04, the major version isn't actually 10; it's >> 10.04 >> and 10.10 isn't a patch release to 10.04. When Ubuntu does do a minor >> release >> for a distribution, they add it as the Z part of the X.Y.Z - for example, >> 14.04.1 should have a major release of 14.04 and a minor release of 1, >> not 4. >> >> >> Thus, our inclination here is to correct the long-standing, incorrect >> version >> reporting we’ve historically had for Ubuntu. >> >> >> A simple, backwards-compatible way to work with this value in your >> existing >> manifests would be to use an approximate regex match on the fact value, >> i.e: >> `if $lsbmajdistrelease =~ /^12/ …` >> > > I also agree with the rationale of the fix, but I have lsbmajdistrelease > in my hiera config and this workaround does not work there. A quick grep > through my puppet manifest repo shows several modules like postgres broken > by this change [1]. Some warnings, deprecations, clear release notes and > work to make sure modules are compatible with the change would have made > this transition much less painful for everyone. A "backwards compatible" > release shouldn't require so many code changes to maintain behavior. > > [1]: https://github.com/puppetlabs/puppetlabs-postgresql/blob/ > master/manifests/params.pp#L121 > > -- > Konrad Scherer, MTS, Linux Products Group, Wind River > > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Puppet Users" group. > To unsubscribe from this topic, visit https://groups.google.com/d/ > topic/puppet-users/Ve0L1iW3NeU/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/puppet-users/53FDD3D6.8020908%40windriver.com. > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/CAOHkZxMrbGVo%2BA%3DiM8gd4hTk8kn_FyBZmFb1s9D_ppEiomkoNw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
