On Thu, Aug 28, 2014 at 08:13:21AM -0700, Matt Wise wrote: > I'll start out by saying that we've worked around the problem ... but, > when you're operating in cloud and constantly booting new machines, > dependencies like Facter are rarely explicitly versioned. That is to say, > often you will see someone pin the version of Puppet that they install, > but they may not pin the version of Facter because its just one of many > Puppet dependencies. That means that its unlikely that people will read > the release notes before they find themselves surprised that Facter is > suddenly reporting new and interesting information. > I honestly think its better practice to revert the change and then plan a > future major version release where you flip that setting. You could add in > a big warning-message that says 'hey, in the next release we're going to > break $lsbmajdistrelease...' which would get peoples attention to.
Humourously, has anybody filed a ticket with Canonical to have Ubuntu not use a dot in their major version number? > All of that said, we're fixed now .. so I'll stop griping. :) > Matt Wise > Sr. Systems Architect > Nextdoor.com > > On Wed, Aug 27, 2014 at 3:51 PM, Kylo Ginsberg <[1][email protected]> > wrote: > > On Tue, Aug 26, 2014 at 11:57 PM, Daniele > Sluijters <[2][email protected]> wrote: > > Hey, > I agree with the spirit of the fix but the fact that it isn't > mentioned anywhere in the release notes is a bit annoying. > > Yep, it's a release notes fail, and it happened because we didn't track > the change with separate tickets. What happened is we made this change > as part of adding lsbminordistrelease ([3]FACT-637) and adding the new > 'os' structured fact ([4]FACT-614), but it wasn't called out > separately. Anyway that's an explanation, but not really an excuse - we > dropped the ball on publicizing this change. > We've added tickets for the changes and pushed updated release notes for > facter 2.2 [5]here. > > > I personally also consider this a backwards incompatible release, > you're changing old behaviour. Albeit for the better, but people > depended on that behaviour and no prior warning or deprecation warning > was issued. > > Although we clearly should have documented this differently, since it's > in the wild and there's consensus that this change *is* for the better, > we'd like to leave it be. > But going forward there's a question about how to handle changes to fact > *values*. One proposal is that we identify (and of course test against) > some essential facts that we "care a lot about" (such as > 'lsbmajdistrelease") and set some rules, like: > (a) we do not change those in x.y.Z releases > (b) we highlight it when they DO change in x.Y or X releases > > Do also keep in mind that though we can easily fix our own manifests > with a regexp match, since the launch of the Forge people have started > to use more and more modules maintained by others. Unless the > maintainer has already issued an update you're stuck with manually > patching an upstream module and carrying that change. Depending on how > you deploy your environment this might be difficult to do. > > I grep'd my way through forge modules looking for affected modules and > there are actually just a handful (3 related to postgresql, and 3 > others). I'll ping those authors to let them know. There's already a fix > in for puppetlabs-postgresql. > Btw, one last thing: another plug for the [6]recently announced nightly > repos, which would have exposed this issue if we'd had repos all in > place ahead of time (this change went in two weeks before release). > Thanks! > -- > Kylo Ginsberg > [7][email protected] > Join us at [8]PuppetConf 2014, September 20-24 in San Francisco > Register by September 8th to take advantage of the [9]Final > Countdown —save $149! > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Puppet Users" group. > To unsubscribe from this topic, visit > > [10]https://groups.google.com/d/topic/puppet-users/Ve0L1iW3NeU/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [11][email protected]. > To view this discussion on the web visit > > [12]https://groups.google.com/d/msgid/puppet-users/CALsUZFHQ_Pho_%2Bq9VCBMdMhe4DjcZRhvmF5NU74wTU-DXoZ9xg%40mail.gmail.com. > For more options, visit [13]https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [14][email protected]. > To view this discussion on the web visit > > [15]https://groups.google.com/d/msgid/puppet-users/CAOHkZxOrMRd4Tgki7kv2kzPfrgP9A6nFs0dCMXj2xLZhvhXXkg%40mail.gmail.com. > For more options, visit [16]https://groups.google.com/d/optout. > > References > > Visible links > 1. mailto:[email protected] > 2. mailto:[email protected] > 3. https://tickets.puppetlabs.com/browse/FACT-637 > 4. https://tickets.puppetlabs.com/browse/FACT-614 > 5. https://docs.puppetlabs.com/facter/2.2/release_notes.html > 6. https://groups.google.com/forum/#!topic/puppet-users/gtXrUgQZmJ0 > 7. mailto:[email protected] > 8. http://www.puppetconf.com/ > 9. > https://www.eventbrite.com/e/puppetconf-2014-tickets-7666774529?discount=FinalCountdown > 10. https://groups.google.com/d/topic/puppet-users/Ve0L1iW3NeU/unsubscribe > 11. mailto:[email protected] > 12. > https://groups.google.com/d/msgid/puppet-users/CALsUZFHQ_Pho_%2Bq9VCBMdMhe4DjcZRhvmF5NU74wTU-DXoZ9xg%40mail.gmail.com?utm_medium=email&utm_source=footer > 13. https://groups.google.com/d/optout > 14. mailto:[email protected] > 15. > https://groups.google.com/d/msgid/puppet-users/CAOHkZxOrMRd4Tgki7kv2kzPfrgP9A6nFs0dCMXj2xLZhvhXXkg%40mail.gmail.com?utm_medium=email&utm_source=footer > 16. https://groups.google.com/d/optout -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/20140828152212.GA22842%40iniquitous.heresiarch.ca. For more options, visit https://groups.google.com/d/optout.
