Instead of just printing a normal warning, use log_warn, which adds a warning to the whole task. This means the whole task ends with a "warning" status which is visible nicely in the task list. Previously we just printed a warning, which made the task end with "OK" even if the reload failed.
frr-reload.py only fails if it's not installed (where a warning status is ok) or the configuration is not valid (where a warning status is also ok). Having frr-reload.py uninstalled for some reason and always relying on `systemctl restart frr` to reload the sdn config is kinda weird and you probably deserve to get a warning on each sdn apply task. Signed-off-by: Gabriel Goller <[email protected]> --- src/PVE/Network/SDN/Frr.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm index b548e7b4f0fe..b607b32c248d 100644 --- a/src/PVE/Network/SDN/Frr.pm +++ b/src/PVE/Network/SDN/Frr.pm @@ -70,7 +70,7 @@ sub apply { eval { reload() }; return if !$@; - warn "reloading frr configuration failed: $@"; + log_warn("reloading frr configuration failed: $@"); warn "trying to restart frr instead"; } -- 2.47.3 _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
