On Thu, 11 Sep 2025 17:33:54 +0200, Gabriel Goller wrote:
> Instead of just printing a normal warning, use log_warn, which adds a
> warning to the whole task. This means the whole task ends with a
> "warning" status which is visible nicely in the task list. Previously we
> just printed a warning, which made the task end with "OK" even if the
> reload failed.
> 
> frr-reload.py only fails if it's not installed (where a warning status
> is ok) or the configuration is not valid (where a warning status is also
> ok). Having frr-reload.py uninstalled for some reason and always relying
> on `systemctl restart frr` to reload the sdn config is kinda weird and
> you probably deserve to get a warning on each sdn apply task.
> 
> [...]

Applied, thanks!

[1/1] frr: print task warning when frr reload fails
      commit: ea13baa9af4cff1c2dbc096a757b4c0a94afaa56


_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to