Am 09/01/2024 um 15:23 schrieb Alexander Zeidler: > and point users to proxmox-offline-mirror-helper
the change is fine, but having any background/reason/why here could be still nice, I never saw a commit with to much references or reasons state for why a change was done, and having those can definitively help when looking at that in the future – as in contrast to the "what/how it changed" (which basically is encoded in the diff itself) this might not be recoverable in the future. For any patches documenting the reason and background is most of the time the important thing to do in the commit message. Especially for small/docs patches the what/how can be nice for when skimming the `git log` wihtout changes visible, but it's definitively a bit less important in the commit message body. _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
