>>So there are no other side effects (i.e. kvm crashes)? 
Yes, I doesn't crash.

The device_del command is async (return always), but waiting to have acpi 
unplug ack from guest
before remove the device. (we list the devices to see if it's remove)

So it doesn't crash.


>>If so, we can enable it by default. 
I'll make a patch.
(And maybe also convert some hmp to qmp, device_del, device_add).

Do you want to display an hotplug option in pve-manager ? (If users want to 
disable hotplug ?)


----- Mail original ----- 

De: "Dietmar Maurer" <diet...@proxmox.com> 
À: "Alexandre DERUMIER" <aderum...@odiso.com>, pve-devel@pve.proxmox.com 
Envoyé: Mardi 19 Février 2013 06:47:25 
Objet: RE: [pve-devel] activate hotplug by default ? 

> Currently the Unplug Hang, as the device cannot be removed from qemu. 
> (Don't know if they are a workaround to force removal) 
> 
> So we just have an error message in pve-manager at removal. 

So there are no other side effects (i.e. kvm crashes)? 
If so, we can enable it by default. 
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to