>>maybe via a global datacenter configuration (planning). Maybe can we simply keep current hotplug option:
0: disable hotplug/unplug 1: enable hotplug/unplung for all devices except unplug for disks 2 : enable hotplug/unplug for all devices and expose only values 0/1 in gui ? Another way, as some new hotplug devices are coming this year (memory,cpu), could be use of binary flag 0 : disable 1: nic hotplug 2: nic unplug 4: disk hotplug 8: disk unplug 16: cpu hotplug 32: cpu unplug .... so nic hotplug + nic unplug + disk hotplug = 1 + 2 + 4 = 7 And we can easily change the default value and add new features in time. Or is it too complex ? ----- Mail original ----- De: "Martin Maurer" <mar...@proxmox.com> À: pve-devel@pve.proxmox.com Envoyé: Mardi 19 Février 2013 19:17:17 Objet: Re: [pve-devel] activate hotplug by default ? > -----Original Message----- > From: Alexandre DERUMIER [mailto:aderum...@odiso.com] > Sent: Dienstag, 19. Februar 2013 18:53 > To: Dietmar Maurer > Cc: pve-devel@pve.proxmox.com; Martin Maurer > Subject: Re: [pve-devel] activate hotplug by default ? > > >>hot-unplug looks dangerous for me anyways - maybe we should only allow > >>hot-add for disks? > Yes, no problem for me. I also vote for this. Hot-unplug is too dangerous as default setup. > Sure It's dangerous if your disks are mounted. (Maybe with guest-agent in > the futur we could check if the disks are mounted or not). > It could be great to keep an option to activate disk hot-unplug for advanced > users. maybe via a global datacenter configuration (planning). > > About the windows "bug": > > I found a way, with calling drive_del after device_del. > windows acpi don't unplug the disk until it's mounted, so it's safe, and we > keep access to disk > > But on Linux that doesn't work, the device removal hang. > (Normal linux behaviour was to remove correctly the device, but of course, > mount point is hanging) > > > I don't like too much this kind of trick which depend of the guest os. > (Anyway libvirt implement drive_del before device_del, to be sure that datas > are correctly flushed) > > > So I think guest-agent is the only 100% safe way for removal. That sounds better, yes. Martin _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
