On 9/19/18 10:01 AM, Dietmar Maurer wrote: >> You could do this automatically for all VMs, while it comes from >> windows it's intended to be guest OS agnostic and is exposed over >> fw_cfg/ACPI, AFAIS.[0] >> >> Maybe add none if there's any "hide that we virtualize" flag is on, >> but else I do not really see a point in not doing this? >> (allowing to let the user disable it with '0', seems nonetheless >> a possible reasonable option) > > I would not add a enable option - either the property is there or not. > We can pass a special value (maybe '1') to trigger generation. >
Hmm, I agree with the 'it's there or not', Your "add and generate one on '1'" is essentially the mirrored from my "always generated one if not '0'" (for new or cloned VMs) approach, though. But, concluding from their docs[1] and Dominiks tests, mine should be the safer default, it makes sense to have this, it can make cloning safer, especially for guests running things like a domain controller[0] or databases - so I'd prefer a default on approach. [0]: https://docs.microsoft.com/en-us/windows-server/identity/ad-ds/get-started/virtual-dc/virtualized-domain-controller-architecture [1]: https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob_plain;f=docs/specs/vmgenid.txt;h=aa9f5186767c22698f9615995c19c05d1e85eb39;hb=HEAD _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
