Awesome, Sam! Looks great! Thanks for checking it in! Murali
On 8/16/07, Sam Lang <[EMAIL PROTECTED]> wrote: > > Went ahead and committed your patch with the changes I mentioned. > Also, I made the -a <alias> argument to pvfs2-server optional. If it > isn't specified, the hostname component is tried. > > I also added a script that converts from the old config file format > to the new single config file. > > Attached is the patch of the changes I committed. > > -sam > > > > > On Aug 16, 2007, at 1:57 PM, Murali Vilayannur wrote: > > > Hey Sam, > > Ah I see.. Sure.. I think your format looks far more pleasing to > > the eye! > > No objections :) > > thanks, > > Murali > > > >> <ServerOptions> > >> > >> Option Logfile myhost1 /tmp/s1 > >> Option StorageSpace myhost1 /sandbox/sto > >> Option Logfile myhost2 /tmp/s2 > >> Option StorageSpace myhost2 /pvfs/storage > >> </ServerOptions> > >> > >> I'd rather have: > >> > >> <ServerOptions> > >> Server myhost1 > >> Logfile /tmp/s1 > >> StorageSpace /sandbox/sto > >> </ServerOptions> > >> > >> <ServerOptions> > >> Server myhost2 > >> Logfile /tmp/s2 > >> StorageSpace /pvfs/storage > >> </ServerOptions> > >> > >> I think it will make the server-config.c parsing code a bit easier, > >> and allows for encapsulation of a bunch of options for one server in > >> a specific context. I've been playing with the code a bit and should > >> have something done soon. Objections? > >> > >> -sam > >> > >> > >> On Jun 20, 2007, at 1:19 AM, Murali Vilayannur wrote: > >> > >>> Hey Sam, > >>> Any interest in merging this patch to unify config files while > >>> starting up pvfs2 servers? > >>> I have reworked it against HEAD.. > >>> Relevant thread.. > >>> http://www.beowulf-underground.org/pipermail/pvfs2-developers/2007- > >>> February/003209.html > >>> thanks, > >>> Murali<unify-config-files.patch> > >> > >> > > > > > > _______________________________________________ Pvfs2-developers mailing list [email protected] http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
