I found a spot in the PINT_manager_complete_op function where Sam's patch removed a free(entry) at the end of the function. I am going to contact Sam and see if he has any thoughts about that particular free that he removed.
Becky See below, too! On Thu, Jun 30, 2011 at 5:11 PM, Benjamin Severs <[email protected]>wrote: > On Thursday, June 30, 2011 15:42:28 Becky Ligon wrote: > > > http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/2 > > 0101020/068fd427/pint-mgmt-opid-cleanups-0001.obj > > > > Bart/Ben: > > > > Above is a link to the patch that was in the pvfs2-developers archive. > It > > has alot more stuff in it than the patch that you just sent me. In > > addition, Sam made a comment about the pint-mgmt.c change indicating that > > memory would not be released unless other changes were made. So, I'm > > thinking that the changes I applied to OrangeFS included everything that > > Sam intended and not just a quick solution. Please take a look at this > > link and see if your code has these same changes. These changes may be > > contributing to your memory problem, but we also think there still may be > > something else as well. > > > > Becky > > Becky, > > The referenced pint-mgmt-opid-cleanups-0001.obj patch above is the exact > same > commit that I've identified as causing the memory leak. If we revert that > change from the OrangeFS code, the memory leak ceases. So, it appears that > something isn't right with the changes Sam made. When you said that Sam > made > a comment about the pint-mgmt.c change, was he talking in reference to this > pint-mgmt-opid-cleanups-0001.obj change or the one Bart sent you that was > just > an early return on error. > He was referring to the early return on error, I think. > > Also, we are indeed testing with both the 2.8.2 branch and the latest > OrangeFS > code and both code bases have this change in them. > Okay. Thanks. I still haven't found the changes in the 2.8.2 branch but I may not be looking correctly. Becky > > -- > Benjamin Severs > -- Becky Ligon OrangeFS Support and Development Omnibond Systems Anderson, South Carolina
_______________________________________________ Pvfs2-developers mailing list [email protected] http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
