Thanks to some direction by Phil Carns, we've managed to correct the memory
leak that was affecting directio operations. Below is the patch that addresses
the issue. The problem was that once all the *fast* calls were switched to
*safe* calls, the proper cleanup routines were never being called. We simply
placed the cleanup logic that was present in the PINT_context_test_* methods
after the PINT_manager_complete_op call.
diff --git a/src/common/mgmt/pint-worker-threaded-queues.c
b/src/common/mgmt/pint-worker-threaded-queues.c
index 1359768..a088e3f 100644
--- src/common/mgmt/pint-worker-threaded-queues.c
+++ src/common/mgmt/pint-worker-threaded-queues.c
@@ -423,6 +423,7 @@ static void *PINT_worker_queues_thread_function(void *
ptr)
{
for(i = 0; i < op_count; ++i)
{
+ struct PINT_op_entry *op_entry;
op = PINT_op_from_qentry(qentries[i]);
/* service the operation */
ret = PINT_manager_service_op(
@@ -440,6 +441,14 @@ static void *PINT_worker_queues_thread_function(void *
ptr)
/* fatal if we can't complete an op */
goto free_ops;
}
+
+ op_entry = id_gen_safe_lookup(op->id);
+ if(op_entry)
+ {
+ id_gen_safe_unregister(op_entry->op.id);
+ free(op_entry);
+ op_entry = NULL;
+ }
}
}
}
--
Benjamin Severs
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
