On Tue, 07 Jun 2011 11:49:52 +0200, Tomasz Rybak <[email protected]> wrote:
> Hello.
> I attach patch bringing new CURAND 4 features to PyCUDA.
> Because there is more Sobol generator types, I decided
> to introduce inheritance: _SobolRandomNumberGeneratorBase
> and _ScrambledSobolRandomNumberGeneratorBase both
> inherit from _RandomNumberGeneratorBase and are inherited
> by proper Sobol{32,64}RandomNumberGenerator classes.
> This leaves repetition in Sobol64 and ScrambledSobol64
> concerning methods accepting 64-bit arguments, but
> I do not have idea how to solve it without complicating code.
> 
> I have not yet added curand_log_normal kernels - unlike
> other kernels they require additional parameters. I wanted
> to focus on bringing new types to PyCUDA first, and only
> then try to extend classes by adding new kernels.

Looks good. Can you add some simple docs? I'd consider it ready to merge
once that's done.

Andreas

Attachment: pgp3VL4CMyygu.pgp
Description: PGP signature

_______________________________________________
PyCUDA mailing list
[email protected]
http://lists.tiker.net/listinfo/pycuda

Reply via email to