Hi Freddie,

I think surface anti-aliaisng is fine because we integrated and convert
back for each surface.

However, when we integrate force, we add all face integration and we
need to consider the area of face. I think |J| does not have this
information. When we use a straight triangle, |J| is the same for every
solution/flux points but length of edge is different. I think it is
similar situation when we compute gbasis_coeff.

Regards,

Jin Seok

On Wed, 2015-06-10 at 18:46 +0100, Freddie Witherden wrote:
> Hi Jin Seok,
> 
> On 10/06/2015 18:41, Jin Seok Park wrote:
> > I have pushed a fix for this plugin on my develop branch.
> > 
> > I have checked this for a few initial step and the result seems a 
> > reasonable value.
> > 
> > If possible, could you please test it?
> 
> I see the fix although note that this is not something that we do when
> surface anti-aliasing.  I was under the impression that this factor
> should be baked into |J| for the face in question (which we pick up on
> through mag_norm_pnorm).
> 
> Could there also be a bug in the surface anti-aliasing code then?
> 
> <https://github.com/FreddieWitherden/PyFR/blob/develop/pyfr/shapes.py#L1
> 04>
> 
> Regards, Freddie.
> 

-- 
Dr. Jin Seok Park PhD
Postdoctoral Researcher
Department of Aeronautics
Imperial College London
London, UK, SW7 2AZ

-- 
You received this message because you are subscribed to the Google Groups "PyFR 
Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send an email to [email protected].
Visit this group at http://groups.google.com/group/pyfrmailinglist.
For more options, visit https://groups.google.com/d/optout.

Reply via email to