Looks pretty good to me. Unless I'm mistaken, it looks like Sprite.position is missing the setter? I see Sprite.set_position, but according to the old code, Sprite.set_position was also the setter for the position property. I would resolve this by creating a Position.setter that calls Sprite.set_position. My other comment is that your PR also changes the triple-quotes around the docstrings. I don't mean to be pedantic, but since the rest of pyglet uses triple single-qoutes ( ''' ) instead of ( """ ), then I think that should be left unchanged. Just my 2 cents. Other than that, it looks correct to me.
On Wednesday, October 28, 2015 at 3:20:34 AM UTC-5, Benjamin Moran wrote: > > I've made a pull request for my refactored sprite module. There aren't > really any code changes or docstring changes, so I don't think anything > should be affected. If there are any issues I can fix it up. > > > On Tuesday, October 27, 2015 at 7:29:14 PM UTC+9, Rob wrote: >> >> That is also the reason I use future for the compatibility. It makes >> python 3 code run on python 2, so you are backwards compatible instead of >> the other way around. >> >> Rob >> On 27 Oct 2015 10:05, "Leif Theden" <leif....@gmail.com> wrote: >> >>> Ubuntu and arch Linux are shipping with Python 3 as the default and >>> probably others as well. For a least a few years though Python 2 needs to >>> be supported. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "pyglet-users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to pyglet-users...@googlegroups.com. >>> To post to this group, send email to pyglet...@googlegroups.com. >>> Visit this group at http://groups.google.com/group/pyglet-users. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to pyglet-users+unsubscr...@googlegroups.com. To post to this group, send email to pyglet-users@googlegroups.com. Visit this group at http://groups.google.com/group/pyglet-users. For more options, visit https://groups.google.com/d/optout.
