The changes look good, Dan. It's too bad there isn't a better way to handle the library names on Windows, but I think the code looks fairly clean as you've written it. In the case where a developer is going to bundle the binaries, they can just name them whatever they want.
I'll have to get that media_player rewritten soon, and see about implementing proper frame catch-up functionality. On Monday, March 27, 2017 at 10:15:55 PM UTC+9, Daniel Gillet wrote: > > Hi Benjamin, > > Thank you for giving this a try. I'm glad things are looking better. > > I pushed a few more commits which tackle some of the points you made. In > no particular order: > > - Using pyglet.options to define the FFmpeg dll names under Windows. I > didn't use it for the other platforms, using the default names. This would > ensure you could distribute your code for all platforms. For Windows you > would have to provide the FFmpeg binaries. For Linux / OS X, you could > rely > on a default install. And if not, you could still provide the binaries. > But > with these 2 platforms, the version in the filename is not a problem, and > it comes after the filename extension, if I understood it correctly. > - I used pyglet.compat_platform as you suggested. > - I tried the video you provided and I could reproduce the bug. It was > a subtle bug, ie. Heisenbug, as it would disappear as soon as I would turn > on the debug messages. But I could finally find out where it came from. So > please, let me know how the seeking is now working for you. > As a side note, it's *normal* that seeking only brings you to an > approximate point in time. It's the application responsibility to skip the > first frames until the correct point in time is found. This is something > the media player is not doing. We could try to implement it to illustrate > how to do it. > - I removed all the references to AVbin. I thought it was confusing to > refer to this lib which is not used. I can imagine the confusion for > someone trying to read the code. He would not understand why there are > some > classes called AVbinXXX while we're wrapping FFmepg. > > I guess there should be some work going to the documentation. I never > built pyglet documentation, so I guess I'm good for some more reading. :) > > Dan > -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to pyglet-users+unsubscr...@googlegroups.com. To post to this group, send email to pyglet-users@googlegroups.com. Visit this group at https://groups.google.com/group/pyglet-users. For more options, visit https://groups.google.com/d/optout.
