On Tue, Feb 10, 2009 at 07:28:21AM -0800, Istvan Albert wrote:
-> On Feb 10, 10:10?am, "C. Titus Brown" <[email protected]> wrote:
-> 
-> > Now, any comments on the actual source code, performance, or interface?
?:)
-> > This is Alex's first independent package and I've more or less given
him
-> > free rein, so comments or criticisms would be very welcome.
-> 
-> I'd love to take a look, once I am able to compile it. After brief 30
-> minute stint I was unable to. Truth to be told I don't know much about
-> cmake or what type of files it generates for windows, and those are
-> aplenty.
-> 
-> one thing that it seems nonstandard is using an initialized field to
-> specify an array size is seen like an error in Visual Studio:
-> 
->         unsigned fieldsize = 100;
-> -       char fieldname[fieldsize];
-> +       char fieldname[100];

->Ahh, ok, we didn't test it explicitly on Windows. Whoops.

->Hmm, Alex, any thoughts?  I thought this was actually a standard feature
->of C++.

Ahh alright, I wonder if #defining that would fix the error on windows as
well? I want to leave that value referenced by name since it is used at
another location in the code (instead of just calling 100). Once I get
Visual Studio installed I'll start doing more tests on Windows.

-> until I also tried it on linux , as it turns out all binaries built with
cmake fail right away there as well with:
->
-> terminate called after throwing an instance of 'std::logic_error'
->      what():  basic_string::_S_construct NULL not valid Aborted

Hmm, you say all binaries built with cmake fail; have you made a custom
Makefile then?


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"pygr-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/pygr-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to