On Mon, Mar 16, 2009 at 08:56:09AM -0700, Christopher Lee wrote: -> -> Hi Titus, -> I've tried out the change that you suggested for moving the storage -> initialization and strslice() code to FileSequenceDB. I agree with -> you that all this code seems more naturally to be a part of the -> sequence database class, and I'm hoping that this will make this class -> less confusing to people. This allowed me to get rid of -> _init_subclass from two classes (FileDBSequence and XMLRPCSequence). -> -> I pushed this change to master; get the latest code from the public -> git repository. -> -> One minor point: FileDBSequence.__len__() directly uses an internal -> interface (seqLenDict), which feels a little unmodular, as does the -> descriptor class used to provide the seq property on this class.
Hi Chris, I'm hoping that you did this in my seqdb review branch -- you know, the one with all the whitespace changes and documentation additions and tests...? <sigh> OK, I'll integrate those changes into my seqdb review branch. But please, if we are to have any hope of integrating MY refactorings don't change seqdb in master! ;) thanks, --titus -- C. Titus Brown, [email protected] --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pygr-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/pygr-dev?hl=en -~----------~----~----~----~------~----~------~--~---
