On Jun 3, 2009, at 7:24 PM, Marek Szuba wrote:

> - compare the number of tuples in real and expected output, with some
>   latitude (+-2 entries for blastp, +-10 for multiblast);
> - scan all fields in real output for syntactic correctness: fields 0
>   and 1 must be strings matching a certain regular expression (three
>   capital letters optionally followed by another capital letter or a
>   digit, an underscore, two to five capital letters), field 2 must be
>   a number from the range 0. < x <= 1.;
> - require strict agreement between the two data sets only for entries
>   with identity ratio above 50 %.

Looks reasonable to me.

>
>
> With such changes in place, blast_test.py no longer fails. However,
> note that this work is not complete - relaxed checks must also be
> implemented in test_blastx() and test_tblastn(). I'll take care of  
> that
> tomorrow. By the way, Chris - haven't you said once the TBLASTN test
> could be re-written so that it has exactly the same form as the BLASTX
> one?

yes.  I don't think the tblastn assertEqual tests are very useful.

>
>
> Please let me know what you think.

Once you add the remaining relaxed tests, we can push this to master,  
as far as I'm concerned.

Thanks!

-- Chris

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"pygr-dev" group.
To post to this group, send email to pygr-dev@googlegroups.com
To unsubscribe from this group, send email to 
pygr-dev+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/pygr-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to