On Wed, 3 Jun 2009 22:32:25 -0700
Christopher Lee <l...@chem.ucla.edu> wrote:

> Once you add the remaining relaxed tests, we can push this to
> master, as far as I'm concerned.

I have relaxed the BLASTX test

http://github.com/mkszuba/pygr/commit/defb05fa5c03732f61a17cd2396c579e20dbc447

as well as rewritten the TBLASTN one to use the same checking logic

http://github.com/mkszuba/pygr/commit/5d65132f580302d0a62341c26f853375d79a2893

(please have an extra-close look at this one to verify I haven't messed
this up). This time the check consists of the following parts:

 - compare the number of tuples in real and expected output, with some
   latitude, i.e. +-2 entries, for blastx (none for tblastn since only
   one tuple is checked there);
 - scan all fields in real output for syntactic correctness: the
   value in field 2 must be three times that in field 0, field 3 must
   be a number from the range 0. < x <= 1.;
 - require strict agreement between the two data sets only for entries
   with identity ratio above 50 %.

One more thing we could do before closing this issue is merge the two
relaxed-check functions, as they are quite similar. However, I have yet
to decide how this could be done so that the effect is both elegant and
efficient.

-- 
MS

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"pygr-dev" group.
To post to this group, send email to pygr-dev@googlegroups.com
To unsubscribe from this group, send email to 
pygr-dev+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/pygr-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to