Am 07.01.2013 16:46, schrieb D'Arcy J.M. Cain:
> On Mon, 07 Jan 2013 09:17:24 +0100
> Christoph Zwerschke <[email protected]> wrote:
>> Can you have a look into the threading issues? I'm still not clear
>> whether the notification handler should care about threading (i.e.
>> use locks and add a method to run in a thread) or whether we should
>> leave it simple as before (remove the locks and threading import). In
>
> I think that this makes the most sense. We are in the database
> business, not the threading business. In fact, threading isn't even
> required here. It could be a different process.
Ok, I removed that stuff again. I also felt it doesn't belong there.
And I renamed the notification handler to "NotificationHandler" which is
a bit unimaginative and kind of an antipattern
(see http://c2.com/cgi/wiki?DontNameClassesObjectManagerHandlerOrData)
but "Notify" is misleading because it's not about notifying but about
doing something when notified, "WhenNotified" does not express that this
is actually running a loop and "WaitForNotificationAndThenCall" is too
long. I think "Handler" is ok here. It handles notifications.
-- Christoph
_______________________________________________
PyGreSQL mailing list
[email protected]
https://mail.vex.net/mailman/listinfo.cgi/pygresql
