Am 18.11.2015 um 19:04 schrieb D'Arcy J.M. Cain: > I found errors in the TEST_PyGreSQL_classic_connection.py run. The > diff at the bottom of this message fixed some of them but I am not > sure if they should be committed. In any case I don't want to bump > into your work so I will leave you to decide.
Thanks. The problem with host and port is fixed now. The earlier tests used the default values for these and I forgot to adapt the tests.
The other errors are probably caused by running against the Python code from the 4.x branch, but C code from trunk.
Btw, this is another thing we can improve. The Python modules could check if the C library has the same version number as they have.
Also, maybe the TEST_... modules should be moved to a subdirectory "tests" one level higher. Then the running tests won't pick up the pg.py and pgdb.py modules from the same directory and run only when these modules are properly installed. This could prevent problems like the one you noticed.
-- Christoph _______________________________________________ PyGreSQL mailing list [email protected] https://mail.vex.net/mailman/listinfo.cgi/pygresql
