On Thu, Jan 03, 2019 at 10:58:33PM +0100, Christoph Zwerschke wrote:
> Am 03.01.2019 um 22:52 schrieb Justin Pryzby:
> > On Thu, Jan 03, 2019 at 09:49:24PM +0100, Christoph Zwerschke wrote:
> > |+    def query_prepared(self, name, *args):
> > |+    def prepare(self, name, command):
> >
> > One thought ; should "name" be an kwarg with default name='' ?
> 
> Yes, that's a good idea. The parameters would then go in opposite order to
> the underlying libpq method, but it would be more pythonic.

Just a nitpick:

+        If you pass no parameters or pass an empty name, then the last unnamed
+        statement will be executed.

+        the prepared statement with the given name. If you do not specify a
+        name, then the last unnamed statement will be described.

I found the word "last" to be confusing here.

I think postgres simply refers to it as "the unnamed statement", or similar.

Thanks,
Justin
_______________________________________________
PyGreSQL mailing list
PyGreSQL@Vex.Net
https://mail.vex.net/mailman/listinfo/pygresql

Reply via email to