These lines check that the permissions are set correctly before building the source distribution, using a control sample of files. They were added to prevent building a source tarball with bad permissions, which I think happened once when I was using a vboxsf filesystem and everything had 777 permissions. It would be better to keep that check in.

Can you output the $PERMS before the exit to see why it's not working for you?

-- Christoph


Am 19.05.2019 um 14:30 schrieb D'Arcy Cain:
There are a few lines in mktar that don't work.  I am not sure that they
ever did.  I want to make the following change just so that I don't keep
getting the usage message.  The script completes anyway so it doesn't
seem critical but if anyone has a better way to do this test I will do
that instead.

Note that I am talking about trunk.  The existing releases are fine.
This script is only for me to create the tar file.

Index: mktar
===================================================================
--- mktar       (revision 1013)
+++ mktar       (working copy)
@@ -24,14 +24,6 @@
      echo "If something has changed, edit MANIFEST.in and mktar."
      exit 1
  fi
-FILES="mktar mkdocs docs tests pg.py pgdb.py pgmodule.c setup.cfg"
-PERMS=`stat --printf="%a" $FILES`
-if [ $? -eq 0 -a "$PERMS" != '755755755755644644644644' ]
-then
-    echo "Hmmm.  File permissions are not set properly."
-    echo "Use a filesystem with permissions and do a clean checkout first."
-    exit 1
-fi
_______________________________________________
PyGreSQL mailing list
PyGreSQL@Vex.Net
https://mail.vex.net/mailman/listinfo/pygresql

Reply via email to