Hello, I'm evaluating your great patches in ticket #165, adding support for an unified build system using waf. They look great!
Some comments: 1) Is it possible move waf and wscript to the source directory? I think they belong there. I know currently Sconscript is top-level, but I believe that to be a mistake. 2) Can you please add an explicit check against LSB v4 and give an error message? Currently it fails because --lsb-besteffort is not supported, but this does not immediately strike as obvious that LSB v4 is needed. This would surely help people that don't RTFM. 3) On Windows, will it work for people that have Visual Studio? Or does it force people to install mingw? 4) We need to test Mac as well. Do you have access to one Mac computer? Otherwise I can take care of it. 5) Can you please prepare a patch for the documentation as well (doc/source/Manual.rst)? You only need to update a few sections to give the new instructions. Thanks again! -- Giovanni Bajo :: [email protected] Develer S.r.l. :: http://www.develer.com My Blog: http://giovanni.bajo.it Last post: Compile-time Function Execution in D -- You received this message because you are subscribed to the Google Groups "PyInstaller" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/pyinstaller?hl=en.
