Hi,

why does PyInstaller.utils.git try to parse the .git directory and then 
fallbacks to git rev-parse? Always using git rev-parse sounds like a much 
better solution, and it's just a one-liner subprocess call. Parsing the 
internal .git directory is prone to break as git evolves and it's more code too.
-- 
Giovanni Bajo   ::  [email protected]
Develer S.r.l.  ::  http://www.develer.com

My Blog: http://giovanni.bajo.it





-- 
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/pyinstaller?hl=en.

Reply via email to