Am 07.06.2012 19:06, schrieb Giovanni Bajo: > why does PyInstaller.utils.git try to parse the .git directory and then > fallbacks to git rev-parse?
Because calling a subprocess is an expensive operation and get_repo_revision() is called on *every* invocation or import of PyInstaller. So if you are going to always subprocess git, you should find an different way for building the version-number in PyInstaller/__init__.py I doubt, the format of this file will ever change, since it is described in the official git user manual, see <http://www.kernel.org/pub/software/scm/git/docs/v1.7.3/user-manual.html#manipulating-branches>. Nevertheless, the current implementations is wrong, since is does not handle "detached heads" <http://www.kernel.org/pub/software/scm/git/docs/v1.7.3/user-manual.html#detached-head>. -- Schönen Gruß Hartmut Goebel Dipl.-Informatiker (univ), CISSP, CSSLP Goebel Consult http://www.goebel-consult.de Monatliche Kolumne: http://www.cissp-gefluester.de/2011-02-fleisige-datensammler-fur-lukratives-geschaeftsmodell-gesucht Blog: http://www.goebel-consult.de/blog/20060920 Goebel Consult ist Mitglied bei http://www.7-it.de/
smime.p7s
Description: S/MIME Kryptografische Unterschrift
