The rebased Python3 works a treat on Mac OS, so I am trying it out on
Ubuntu and I am hitting the same issues as before, namely that compat.py
does not properly detect virtualenv; and if I hack around that,
hook-site.py does something wrong also.

When I look at compat.py on the two branches,

   Python3

https://github.com/pyinstaller/pyinstaller/blob/python3/PyInstaller/compat.py
   Develop

https://github.com/pyinstaller/pyinstaller/blob/develop/PyInstaller/compat.py

they are quite different, in particular the latter has very different (and
nicer!) code for detecting the use of virtual environment. Also, comparing
hook-site.py,

   Develop

https://github.com/pyinstaller/pyinstaller/blob/develop/PyInstaller/hooks/hook-site.py

...it loads a "fake site.py" that "does nothing."

   Python3

https://github.com/pyinstaller/pyinstaller/blob/python3/PyInstaller/hooks/hook-site.py

...it tests a global, compat.is_venv, which the Develop version of compat
no longer sets at all(!) and when it is true, does a quite inadequate
version of trying to locate the "real" site.py -- no mention of any fake,
or wanting site.py to do nothing.

Does this indicate some problem in the rebase of the Python3 branch?

Thanks for any advice on this,
Dave Cortesi

-- 
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/pyinstaller.
For more options, visit https://groups.google.com/d/optout.

Reply via email to