Hello David,

thanks for your feedback.

> they are quite different, in particular the latter has very different
> (and nicer!) code for detecting the use of virtual environment. Also,
> comparing hook-site.py,

I simply may have done this wrong :-) I'd appreciate a pull-request for
how ever it is correct (I assume it's quicker if you are doing this as
you already worked on this topic). In the commit message, feel free to
state "This was missed when merging in e886b451."

> Also, comparing hook-site.py,

On the python3-branch, there is commit 12de5e2fd saying "Drop
fake-site.py and hook-site.py functionality. No need to have fake code
for site module anymore. Python allows to set run-time flags that just
ignores the packages from site-packages directory." See
https://github.com/pyinstaller/pyinstaller/commit/12de5e2fd

And the corresponding code is in
<https://github.com/pyinstaller/pyinstaller/blob/python3/bootloader/src/pyi_pythonlib.c#L145>,
so I assume it should work. I checked, and even Python 2.7 should be
able to handle this. If it does not work, I'd appreciate a puill-request ;-)


-- 
Schönen Gruß
Hartmut Goebel
Dipl.-Informatiker (univ), CISSP, CSSLP
Information Security Management, Security Governance, Secure Software
Development

Goebel Consult, Landshut
http://www.goebel-consult.de

Blog:
http://www.goebel-consult.de/blog/kleiner-erfahrungsbericht-mit-online-ocr-diensten

Kolumne: http://www.cissp-gefluester.de/2010-06-adobe-und-der-maiszunsler

-- 
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/pyinstaller.
For more options, visit https://groups.google.com/d/optout.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to